Skip to content

[codex] Fix dev stack startup cleanup#24

Merged
Joncallim merged 1 commit into
mainfrom
codex/fix-startup-scripts
Jun 26, 2026
Merged

[codex] Fix dev stack startup cleanup#24
Joncallim merged 1 commit into
mainfrom
codex/fix-startup-scripts

Conversation

@Joncallim

Copy link
Copy Markdown
Owner

Summary

  • replace the macOS-incompatible dev stack cleanup path with process-tree cleanup that works on Bash 3.2
  • pin the web dev server to port 3233 with strict port handling
  • make fixture startup cleanup handle interrupts and show/save daemon build output
  • disable Cargo incremental compilation for startup-oriented daemon builds so corrupt incremental state does not block the testbed

Validation

  • bash -n scripts/run-dev-stack.sh scripts/dockermap-fixture-up.sh scripts/dockermap-fixture-down.sh
  • scripts/dockermap-fixture-up.sh --verify
  • ./scripts/run-dev-stack.sh
  • curl -fsS http://127.0.0.1:4100/daemon/health
  • curl -fsS http://127.0.0.1:4000/api/health
  • Ctrl-C cleanup checked for dev stack; no remaining DockerMap listeners or processes

Notes

  • restored unrelated package-lock.json churn from npm install before committing
  • fixture created during verification was torn down successfully

@Joncallim Joncallim merged commit 7d19f45 into main Jun 26, 2026
7 checks passed
@Joncallim Joncallim deleted the codex/fix-startup-scripts branch June 26, 2026 07:51

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b63f716f14

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/run-dev-stack.sh

echo "[dockermap] starting react web on http://127.0.0.1:3233"
npm --workspace @dockermap/web run dev -- --host 127.0.0.1 &
start_background npm --workspace @dockermap/web run dev -- --host 127.0.0.1 --port 3233 --strictPort

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Tear down the stack on strict-port failure

When port 3233 is already occupied, Vite's --strictPort exits immediately, but this script still reaches the final no-argument wait; help wait says that form waits for all children and returns zero, so the daemon/API keep running and the dev-stack command hangs instead of reporting the web startup failure and cleaning up. Please supervise child exits here (for example, wait for any tracked PID to fail and then run cleanup) so strict-port startup errors actually stop the stack.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant