[codex] Fix dev stack startup cleanup#24
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b63f716f14
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| echo "[dockermap] starting react web on http://127.0.0.1:3233" | ||
| npm --workspace @dockermap/web run dev -- --host 127.0.0.1 & | ||
| start_background npm --workspace @dockermap/web run dev -- --host 127.0.0.1 --port 3233 --strictPort |
There was a problem hiding this comment.
Tear down the stack on strict-port failure
When port 3233 is already occupied, Vite's --strictPort exits immediately, but this script still reaches the final no-argument wait; help wait says that form waits for all children and returns zero, so the daemon/API keep running and the dev-stack command hangs instead of reporting the web startup failure and cleaning up. Please supervise child exits here (for example, wait for any tracked PID to fail and then run cleanup) so strict-port startup errors actually stop the stack.
Useful? React with 👍 / 👎.
Summary
Validation
Notes