Skip to content

[codex] Add Docker testbed procedure#22

Merged
Joncallim merged 1 commit into
mainfrom
codex/testbed-docker-procedure
Jun 25, 2026
Merged

[codex] Add Docker testbed procedure#22
Joncallim merged 1 commit into
mainfrom
codex/testbed-docker-procedure

Conversation

@Joncallim

Copy link
Copy Markdown
Owner

Summary

  • Add a full DockerMap Docker testbed operator procedure.
  • Link the runbook from the docs index, sandbox fixture page, and testing plan.

Validation

  • git diff --cached --check

Notes

  • Docs-only change; live Docker fixture and full test suite were not run locally before commit.

@Joncallim Joncallim merged commit ad26664 into main Jun 25, 2026
7 checks passed
@Joncallim Joncallim deleted the codex/testbed-docker-procedure branch June 25, 2026 16:37

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e72d38761c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Run from the repository root:

```bash
cd /Users/jonathanlim/Documents/GitHub/DockerMap

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace the hard-coded checkout path

In any environment that is not the author's local macOS checkout, following this prerequisite from a fresh shell fails immediately or leaves the operator outside the repo, while every subsequent command uses repo-relative scripts/... paths. Use a generic placeholder such as cd /path/to/DockerMap or tell users to run the commands from their existing repository root so the runbook is actually executable by other maintainers.

Useful? React with 👍 / 👎.

node --version
npm --version
cargo --version
docker version

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Honor the sudo Docker mode in manual checks

For hosts where setup succeeds only through the fixture's supported sudo -n docker fallback, this prerequisite and the later Docker evidence/cleanup commands still invoke bare docker, so the procedure will fail with permission errors even though scripts/dockermap-fixture-up.sh recorded the working command in DOCKER_CMD_TEXT. The runbook should either derive and use that recorded Docker command after sourcing the state file or document the sudo form consistently.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant