feat(decompile): retain canonical SSA sidecar - #752
Open
Jon-Becker wants to merge 1 commit into
Open
Conversation
Contributor
❌ AI Evaluation Suite for 6ee877b📊 View the full HTML evaluation report. 📊 View evaluation scores
|
Contributor
✅ Coverage Report for d7fe889
|
Jon-Becker
force-pushed
the
feat/decompiler-ssa-sidecar
branch
from
September 6, 2026 21:41
839026b to
5af5e2d
Compare
Jon-Becker
force-pushed
the
feat/decompiler-ssa-sidecar
branch
from
September 6, 2026 23:40
5af5e2d to
6ee877b
Compare
Contributor
Benchmark for d7fe889Click to view benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Builds and retains contextual stack SSA inside the decompiler's canonical sidecar.
CanonicalAnalysisnow keeps the ID-consistent tuple of:Program;This makes canonical SSA available to upcoming function recovery and graph-based typed lowering without recomputing analysis or flattening calling contexts. Legacy source and ABI generation remain unchanged.
This PR is stacked on #751.
Notes to reviewers
ExprId,StateVersionId,ContextualPoint, andSsaValueIdrelationships remain scoped to oneCanonicalAnalysisartifact.points_for_selectorand then index the corresponding contextual SSA blocks rather than projecting contexts onto a single block prematurely.How has it been tested?
cargo test -p heimdall-decompiler --lib— 75 passedcargo test -p heimdall-vm --lib— 204 passedcargo check --workspace --all-targets— passedcargo +nightly fmt --all -- --check— passedgit diff --check— passed