feat(vm): add canonical basic-block frontend - #730
Open
Jon-Becker wants to merge 2 commits into
Open
Conversation
Contributor
AI Evaluation SuiteCheck the box below to run the heimdall-eval AI evaluation suite.
|
Contributor
✅ Coverage Report for fefa83f
|
This was referenced Sep 5, 2026
Jon-Becker
force-pushed
the
feat/canonical-basic-block-cfg
branch
from
September 6, 2026 21:37
ef685a2 to
43a4944
Compare
Jon-Becker
force-pushed
the
feat/canonical-basic-block-cfg
branch
from
September 6, 2026 23:40
43a4944 to
0e7ab3a
Compare
Contributor
Benchmark for fefa83fClick to view benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Adds an execution-independent EVM program frontend as the first foundation for improving CFG and decompilation accuracy.
The new
heimdall_vm::core::programmodule:JUMPDEST, control-transfer, halt, and invalid-opcode boundariesJUMPDESTinstructionsThe disassembler now consumes this shared decoder instead of maintaining a second instruction-boundary implementation. This gives later CFG/worklist analysis a single structural representation to build on without changing the existing symbolic executor in this PR.
Notes to reviewers
Key files:
crates/vm/src/core/program.rs: decoded program, blocks, terminators, static edge skeleton, and focused testscrates/vm/src/core/mod.rs: exports the frontendcrates/disassemble/src/core/mod.rs: adopts the shared decoderThis PR intentionally does not route dynamic CFG discovery through the new representation yet. Doing so safely requires the subsequent abstract-state/worklist analysis; forcing the current recursive executor to split at every unconditional jump reduced coverage because its global jump deduplication is not continuation-sensitive.
How has it been tested?
cargo +nightly fmt --check --allcargo clippy -p heimdall-vm -p heimdall-disassembler --all-features -- --allow clippy::new_without_default --allow clippy::redundant_field_names --allow clippy::too_many_arguments --allow clippy::format_in_format_args --allow clippy::should_implement_traitcargo test --workspace --lib --tests