Skip to content

Fix suop2 TPANOP issue#193

Open
RaineyZheng wants to merge 1 commit into
JohnWStockwellJr:masterfrom
RaineyZheng:fix/suop2-TPANOP
Open

Fix suop2 TPANOP issue#193
RaineyZheng wants to merge 1 commit into
JohnWStockwellJr:masterfrom
RaineyZheng:fix/suop2-TPANOP

Conversation

@RaineyZheng

@RaineyZheng RaineyZheng commented Jun 2, 2026

Copy link
Copy Markdown

Fix suop2.c so ptsum is routed to the trace-operation branch instead of the panel-operation branch by correcting the TPANOP boundary constant.

Copilot AI review requested due to automatic review settings June 2, 2026 10:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

The PR modifies a macro definition in suop2.c, changing TPANOP from 7 to 6, which creates a duplicate value with ZIPPOL.

Changes:

  • Changed TPANOP macro value from 7 to 6.
Comments suppressed due to low confidence (1)

src/su/main/operations/suop2.c:1

  • TPANOP is now defined as 6, which collides with ZIPPOL (also 6). These macros appear to be a set of enum-like discriminator values used in a switch on operation type, so duplicates will make it impossible to distinguish between ZIPPOL and TPANOP at runtime. Additionally, PTADD remains 7, which now duplicates the original value of TPANOP and leaves a gap. If the intent was to insert TPANOP in sequence, the subsequent macros (PTADD, PTSUB, PTMUL, ...) should be renumbered to 8, 9, 10, ... so that all values remain unique.
/* Copyright (c) Colorado School of Mines, 2015.*/

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants