Fix suop2 TPANOP issue#193
Open
RaineyZheng wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
The PR modifies a macro definition in suop2.c, changing TPANOP from 7 to 6, which creates a duplicate value with ZIPPOL.
Changes:
- Changed
TPANOPmacro value from7to6.
Comments suppressed due to low confidence (1)
src/su/main/operations/suop2.c:1
TPANOPis now defined as6, which collides withZIPPOL(also6). These macros appear to be a set of enum-like discriminator values used in a switch on operation type, so duplicates will make it impossible to distinguish betweenZIPPOLandTPANOPat runtime. Additionally,PTADDremains7, which now duplicates the original value ofTPANOPand leaves a gap. If the intent was to insertTPANOPin sequence, the subsequent macros (PTADD,PTSUB,PTMUL, ...) should be renumbered to8, 9, 10, ...so that all values remain unique.
/* Copyright (c) Colorado School of Mines, 2015.*/
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix suop2.c so
ptsumis routed to the trace-operation branch instead of the panel-operation branch by correcting theTPANOPboundary constant.