Created model for academic experience - #34
Open
amikable-tech wants to merge 2 commits into
Open
Conversation
to-sta
reviewed
Oct 7, 2023
| degree = models.CharField(max_length=255, blank=False) | ||
| summary = models.TextField(blank=False) | ||
| location = models.CharField(max_length=255, blank=False) | ||
| date_achieved = models.DateField(blank=False) |
Collaborator
There was a problem hiding this comment.
@amikable-tech looks great 😃. Just a few minor things that came to mind:
- Some degrees come with a score and we should add the ability to show the score.
Could look like this:
score = models.FloatField(blank=True)- The
date_achievedfield only gives us an indication when it was achieved but not the duration. I would suggest to rather user start and end DateFields. And make the end fieldblank=Trueto indicate that its in progress.
Collaborator
Author
There was a problem hiding this comment.
Thank you!!
will implement your suggestions now.
@amikable-tech looks great 😃. Just a few minor things that came to mind:
1. Some degrees come with a score and we should add the ability to show the score.Could look like this:
score = models.FloatField(blank=True)2. The `date_achieved` field only gives us an indication when it was achieved but not the duration. I would suggest to rather user start and end DateFields. And make the end field `blank=True` to indicate that its in progress.
to-sta
approved these changes
Oct 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I created the model for academic experience. However I am looking forward to your opinions and corrections.
Please let me know if i am to add or delete anything.
Thanks
Fixes: #5