refactor: wrap course progress updates in MongoDB transactions for atomicity (#1427) - #1468
Open
jayshreerathoreai32-hue wants to merge 2 commits into
Conversation
|
@jayshreerathoreai32-hue is attempting to deploy a commit to the jiya's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for codevibeforyou ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1427
Description
This PR refactors the lesson completion workflow to make all related database operations atomic and consistent.
Previously, completing a lesson triggered multiple independent database writes across the Progress, Analytics, and Notification collections without an atomicity guarantee. If any operation failed midway, earlier writes could remain persisted, leaving the user in a partially updated or inconsistent state.
This PR introduces a centralized transaction-based progress service using MongoDB sessions and multi-document transactions. All lesson completion operations now succeed or fail together, ensuring that progress, analytics, XP, streaks, badges, and notifications remain consistent.
Problem Statement
Lesson completion previously triggered four independent database writes:
Because these operations were executed independently, a failure during any intermediate operation could leave the system in an inconsistent state.
For example, the Progress record could be updated successfully while an Analytics or Notification operation failed. This could result in:
The new implementation ensures that all related operations are handled within a single transaction.
Changes Included
1. New Progress Service
Added:
server/services/progressService.jsThe new service centralizes lesson-completion business logic through the exported function:
recordLessonCompletionThe function is responsible for coordinating all progress-related database operations within a single MongoDB transaction.
Key changes:
mongoose.startSession().session.withTransaction().session.endSession()is always called inside afinallyblock.2. Atomic Database Writes
The following operations now share the same MongoDB transaction:
The overall flow is: