Feat interactive viewer - Suggestion#25
Open
rileyhawk1417 wants to merge 3 commits into
Open
Conversation
- Had to add the pan case in the drawing types. Otherwise it would be difficult to set pan in Interactive Viewer. - BUG: The pan tool is buggy cursor does not revert back to normal after pan case. - BUG: Lines still get drawn during panning. Could be because of the default case in DrawingToolExtensions. Not sure on how to make pan not draw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@JideGuru I was using an older version of your project for reference and managed to get pan and zoom working.
Although the current Flutter Drawing Board code has changed, I was still able to apply the same solution from what I used on my project.
So this PR is meant to serve as a suggestion not a solution, I do know that I probably broke some tests while shifting things around. That's why am putting this as a suggestion, since you might be able to implement it in a way that works better for the code base.
There is also a test video I made.
flutter_drawing_board_pan_test.mp4
There are some things I could not get around to solving.