Skip to content

[Dynamic buffer] Fix max speed issue when there are 8 lanes #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JibinBao wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Dynamic buffer] Fix max speed issue when there are 8 lanes #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/qos/files/dynamic_buffer_param.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,15 @@
},
"BUFFER_PORT_INGRESS_PROFILE_LIST_TABLE": ["[BUFFER_PROFILE_TABLE:ingress_lossless_zero_profile]"],
"BUFFER_PORT_EGRESS_PROFILE_LIST_TABLE": ["[BUFFER_PROFILE_TABLE:egress_lossless_zero_profile]", "[BUFFER_PROFILE_TABLE:egress_lossy_zero_profile]"]
},
"max_speed_8lane_platform": {
"x86_64-mlnx_msn4410-r0": "400000",
"x86_64-mlnx_msn4700-r0": "400000",
"x86_64-mlnx_msn4700_simx-r0": "400000",
"x86_64-nvidia_sn4800-r0": "400000",
"x86_64-nvidia_sn4800_simx-r0": "400000",
"x86_64-nvidia_sn5600-r0": "800000",
"x86_64-nvidia_sn5600_simx-r0": "800000"
}
}
}
6 changes: 4 additions & 2 deletions tests/qos/test_buffer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ def load_test_parameters(duthost):
global TESTPARAM_EXTRA_OVERHEAD
global TESTPARAM_ADMIN_DOWN
global ASIC_TYPE
global MAX_SPEED_8LANE_PORT

param_file_name = "qos/files/dynamic_buffer_param.json"
with open(param_file_name) as file:
Expand All @@ -228,6 +229,7 @@ def load_test_parameters(duthost):
TESTPARAM_SHARED_HEADROOM_POOL = vendor_specific_param['shared-headroom-pool']
TESTPARAM_EXTRA_OVERHEAD = vendor_specific_param['extra_overhead']
TESTPARAM_ADMIN_DOWN = vendor_specific_param['admin-down']
MAX_SPEED_8LANE_PORT = vendor_specific_param['max_speed_8lane_platform'].get(duthost.facts['platform'])

# For ingress profile list, we need to check whether the ingress lossy profile exists
ingress_lossy_pool = duthost.shell('redis-cli -n 4 keys "BUFFER_POOL|ingress_lossy_pool"')['stdout']
Expand Down Expand Up @@ -748,9 +750,9 @@ def make_expected_profile_name(speed, cable_length, **kwargs):
if ASIC_TYPE == 'mellanox':
number_of_lanes = kwargs.get('number_of_lanes')
if number_of_lanes is not None:
if number_of_lanes == 8 and speed != '400000':
if number_of_lanes == 8 and speed != MAX_SPEED_8LANE_PORT:
expected_profile += '8lane_'
elif NUMBER_OF_LANES == 8 and speed != '400000':
elif NUMBER_OF_LANES == 8 and speed != MAX_SPEED_8LANE_PORT:
expected_profile += '8lane_'
expected_profile += 'profile'
return expected_profile
Expand Down