Add Missing Test Files for 11 Themes in Codebase - #8322
Conversation
…dedicated coverage
|
This pull request addresses the issue of missing test files for several themes, which is crucial for maintaining code quality and ensuring that all themes are properly validated. It follows the existing conventions and confirms that the themes meet the necessary accessibility standards. This aligns with past decisions made to implement and document themes accurately in the codebase. Thank you for your contribution, and I look forward to your updates! |
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
Aamod007
left a comment
There was a problem hiding this comment.
Adding missing test files for 11 themes across the codebase — good coverage improvement. CI pending, once green ready to merge.
Labels: level:intermediate (11 files), quality:clean, type:testing, mentor:Aamod007
Aamod007
left a comment
There was a problem hiding this comment.
Re-reviewing after noting the only CI failure is Vercel authorization (not code-related). All other checks (Format · Lint · Typecheck · Test, Production Build, CodeQL) pass. Approving — the Vercel deploy auth is a repo-level config issue, not a code problem.
Description
Fixes #8321
Pillar
Visual Preview
No visual change — pure test additions.
What this PR does
21 of 32 real themes in
lib/svg/themes.tshave a dedicated test file inlib/svg/themes/(hex validity, design-spec match, SVG output check,WCAG AA contrast). 11 didn't:
cyberpunk,cyberpunk_neon,default,enterprise,github,glacier,india,monokai,retro-terminal,solarized_light,tokyonight. Added the missing 11, following theexact existing convention. All 11 themes' real hex values were confirmed
in advance to already pass the WCAG AA contrast check, so no production
color values needed to change.
Checklist before requesting a review:
CONTRIBUTING.mdfile.npm run formatandnpm run lintlocally and resolved all errors.