Fix Generator: Ensure Languages View Respects dim_weekends Parameter - #8318
Fix Generator: Ensure Languages View Respects dim_weekends Parameter#8318ChetanSenta wants to merge 1 commit into
Conversation
…documented behavior
|
Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request addresses an important issue by ensuring that the It's worth noting that similar decisions have been made in the past, such as aligning the STL export tower grid with real weekdays and adding unit tests for timezone normalization. These efforts highlight our commitment to maintaining accuracy and consistency across our features. Thank you for your contribution, and I look forward to your updates! |
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
Aamod007
left a comment
There was a problem hiding this comment.
The dim_weekends parameter was being ignored in the Languages view — good catch. Fix + test. CI failing, please fix.
Labels: level:beginner (2 files, focused fix), quality:clean, type:bug, type:testing, mentor:Aamod007
Aamod007
left a comment
There was a problem hiding this comment.
Re-reviewing after noting the only CI failure is Vercel authorization (not code-related). All other checks (Format · Lint · Typecheck · Test, Production Build, CodeQL) pass. Approving — the Vercel deploy auth is a repo-level config issue, not a code problem.
Description
Fixes #8317
Pillar
What this PR does
dim_weekendsis documented without per-view scoping, andview=languagesis documented as a "top languages skyline" (tower-based) view — but
generateLanguagesSVG()never calledrenderTowers()(the only placedim_weekendswas actually checked), so the param silently had no effecton this view. Added the same weekend-dimming check locally to
generateLanguagesSVG's tower rendering.Changes
lib/svg/generator.tsgenerateLanguagesSVGnow applies the samedimmed-towerclass/opacity to weekend towers whendim_weekends=truelib/svg/generator.test.tsChecklist before requesting a review:
CONTRIBUTING.mdfile.npm run formatandnpm run lintlocally and resolved all errors.