Add Developer Achievement Badges to Compare Page - #8312
Conversation
|
@VanshikaSingh28 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This PR adds a new feature that enhances the compare page with developer achievement badges, which can improve user engagement. It's important to ensure that the SVG output meets the premium quality standards as outlined in the checklist. Additionally, please note that similar past decisions have focused on improving code quality, such as fixing dead code in the calculateStreak function to ensure accurate streak status. If you have any questions or need further assistance, feel free to reach out. Happy coding! |
📦 Next.js Bundle Size Report (Gzipped Sizes)
📊 Summary of Totals
|
Aamod007
left a comment
There was a problem hiding this comment.
Nice addition of Developer Achievement Badges to the Compare page — computeAchievementBadges logic, new component, CompareClient integration, and tests. CI failing, please fix.
Labels: level:advanced (5 files, 687 lines, full feature + tests), quality:clean, type:feature, type:testing, mentor:Aamod007
Aamod007
left a comment
There was a problem hiding this comment.
Re-reviewing after noting the only CI failure is Vercel authorization (not code-related). All other checks (Format · Lint · Typecheck · Test, Production Build, CodeQL) pass. Approving — the Vercel deploy auth is a repo-level config issue, not a code problem.
Description
Fixes #3107
Pillar
Visual Preview
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.