Skip to content

Add Developer Achievement Badges to Compare Page - #8312

Open
VanshikaSingh28 wants to merge 1 commit into
JhaSourav07:mainfrom
VanshikaSingh28:feat/developer-achievement-badges-3107
Open

Add Developer Achievement Badges to Compare Page#8312
VanshikaSingh28 wants to merge 1 commit into
JhaSourav07:mainfrom
VanshikaSingh28:feat/developer-achievement-badges-3107

Conversation

@VanshikaSingh28

Copy link
Copy Markdown
Contributor

Description

Fixes #3107

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel

vercel Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

@VanshikaSingh28 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@retenta-bot

retenta-bot Bot commented Jul 25, 2026

Copy link
Copy Markdown

This PR adds a new feature that enhances the compare page with developer achievement badges, which can improve user engagement. It's important to ensure that the SVG output meets the premium quality standards as outlined in the checklist. Additionally, please note that similar past decisions have focused on improving code quality, such as fixing dead code in the calculateStreak function to ensure accurate streak status. If you have any questions or need further assistance, feel free to reach out. Happy coding!

@retenta-bot retenta-bot Bot changed the title feat: Add Developer Achievement Badges to Compare Page (#3107) Add Developer Achievement Badges to Compare Page Jul 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

Asset PR Size Base Size Difference Status
static/chunks/6559-[hash].js - 10.64 KB -10.64 KB (-100.00%) 🗑️ Deleted
static/chunks/7762-[hash].js 10.73 KB - +10.73 KB (++100%) 🆕 New
static/chunks/app/compare/page-[hash].js 17.70 KB 15.47 KB +2.23 KB (+14.43%) 🔴 Regression
static/css/[hash].css 42.18 KB 41.95 KB +0.23 KB (+0.55%) 🔴 Regression

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 4063.31 KB 4052.50 KB +10.82 KB (+0.27%)
Total CSS 342.32 KB 338.94 KB +3.38 KB (+1.00%)

@Aamod007 Aamod007 added level:advanced Complex contributions involving architecture, optimization, or significant feature work quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. mentor:Aamod007 type:feature New features, additions, or enhancements type:testing Adding, updating, or fixing tests labels Jul 27, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition of Developer Achievement Badges to the Compare page — computeAchievementBadges logic, new component, CompareClient integration, and tests. CI failing, please fix.

Labels: level:advanced (5 files, 687 lines, full feature + tests), quality:clean, type:feature, type:testing, mentor:Aamod007

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewing after noting the only CI failure is Vercel authorization (not code-related). All other checks (Format · Lint · Typecheck · Test, Production Build, CodeQL) pass. Approving — the Vercel deploy auth is a repo-level config issue, not a code problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:advanced Complex contributions involving architecture, optimization, or significant feature work mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:feature New features, additions, or enhancements type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add Developer Achievement Badges to Compare Page

2 participants