Skip to content

Keep a budget's threshold on edit and scope account states to the account - #87

Merged
JetSquirrel merged 3 commits into
mainfrom
fix/budget-rules
Nov 3, 2026
Merged

JetSquirrel merged 3 commits into
mainfrom
fix/budget-rules

Conversation

@JetSquirrel

Copy link
Copy Markdown
Owner

Fixes budget editing, account state badges and untranslated text on Accounts and Rules. There is no linked issue.

What changed

Budgets and rules

  • Editing a budget no longer resets its alert threshold to 80%. BudgetStatus now carries the saved threshold, on both the desktop and web backends, and only an account with no budget gets the default.
  • The rule form shows the chosen account's budget, or warns that the rule won't fire until the account has one.

Account state badges

  • Anomaly and untagged spend badges matched by provider, so one account's problem marked every account from that provider. Both now read the account.
  • An anomaly from a rule that watches a whole provider names no account, so it still matches at provider level and marks all of that provider's accounts.
  • An anomaly or low balance badge is now a link to Alerts, by mouse or keyboard.

Text and accessibility

  • Remaining English strings on Accounts and Rules move to locales/ui.yml, with en and zh-CN.
  • Account links can be reached by keyboard. Row actions and rule switches name their target for assistive technology.
  • The Accounts subtitle now explains that month figures are net of credits and can be negative.

This branch also merges current main, so it has no conflicts with it.

Testing

Run locally on Windows on the merged code, before a final commit that only moved two doc comments and added the changelog:

  • cargo test: 600 passed, 0 failed, 3 ignored. This includes a new test that untagged totals split by account.
  • cargo clippy --all-targets -- -D warnings: clean.
  • cargo +nightly-2026-07-28 check --lib --target wasm32-unknown-unknown: passes. This is a type-check, not the full build-web.sh.

cargo fmt --check passes on the final commit.

Not tested in a real window, and the threshold fix has no test of its own. Please check on desktop:

  • Edit a budget saved with a non-default threshold, change only the amount and save. The threshold stays.
  • With an anomaly or untagged spend on one account, its sibling from the same provider stays unmarked.
  • An anomaly or low balance badge opens Alerts by click, and by Tab then Enter or Space.
  • The longer Accounts subtitle fits at minimum window width and in 简体中文.

🤖 Generated with Claude Code

JetSquirrel and others added 3 commits November 3, 2026 23:45
…ount

Editing a budget reset its alert threshold to 80, because the status carried
no threshold to prefill from. It does now, and only an account with no budget
gets the default. The rule form says what the chosen account's budget is, or
that the rule won't fire until it has one.

The Accounts state badge matched anomalies and untagged spend by provider, so
one account's problem marked its siblings. Both now read the account, and an
unscoped rule still matches at provider level. An anomaly or low balance badge
opens Alerts.

Also move the remaining English strings on Accounts and Rules into the locale
file, and label the row actions, account links and rule switches for assistive
technology.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in the arch bridge app icon, billing snapshots, reconciliation and the
monthly report.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JetSquirrel
JetSquirrel merged commit be75323 into main Nov 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant