Repository navigation
Wrap up the AWS work: keep its docs with the plugin, fix what validation found - #56
Merged
Merged
Conversation
…ion found Manual validation on 2026-11-03 found two problems, neither specific to AWS: - The inspector said a property was masked, then listed its value. The list now masks what evidence masks. - Open investigation was only in the native File menu, which Windows doesn't show. It's now in the Graph menu too. The exposure rules' document moves to plugins/aws/README.md, which also says the plugin is an example with no new rules planned. Release baselines from the same validation go in the gates document. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the AWS work without adding to it. No rule, field or resource type changes, and no change to what the plugin returns.
What changes
docs/exposure-rules.mdis nowplugins/aws/README.md, and opens by saying the plugin is an example, maintained, with no new rules or resource types planned. Links are updated.Masked as possible secrets: api_token, then listed the value just below. The property list now uses the same masking as evidence. Query result tables still show raw values, since they're what the query returned.docs/investigations.mdsays so.docs/investigation-gates.md, from the manual validation of 2026-11-03. I checked the figures against that run's raw JSON, but didn't re-measure them.Boundary check
Outside
plugins/aws, AWS appears in host code only in test data, comments, the secret-shape check for access key IDs, andBUILTIN_PLUGINS, which ships the plugin in the app. An existing test stops the canvas and explorer naming AWS rules or labels.Testing
cargo clippy --locked --workspace --all-targets -- -D warningsis clean, andcargo test --locked --workspacegives 356 passed, 0 failed, 1 ignored on Windows. CI will cover macOS.api_tokenshows[redacted]in the list with other properties intact, and Graph > Open investigation… opens the file picker. I cancelled the picker, so opening a file from it wasn't checked;khonsu openuses the same code after the picker.Issue status
Refs #33, #34, #35, #36
🤖 Generated with Claude Code