Skip to content

Wrap up the AWS work: keep its docs with the plugin, fix what validation found - #56

Merged
JetSquirrel merged 1 commit into
mainfrom
chore/wrap-up-aws
Nov 3, 2026
Merged

JetSquirrel merged 1 commit into
mainfrom
chore/wrap-up-aws

Conversation

@JetSquirrel

Copy link
Copy Markdown
Owner

Finishes the AWS work without adding to it. No rule, field or resource type changes, and no change to what the plugin returns.

What changes

  • AWS docs move to the plugin. docs/exposure-rules.md is now plugins/aws/README.md, and opens by saying the plugin is an example, maintained, with no new rules or resource types planned. Links are updated.
  • The inspector no longer shows what it says it masked. It said Masked as possible secrets: api_token, then listed the value just below. The property list now uses the same masking as evidence. Query result tables still show raw values, since they're what the query returned.
  • Open investigation is reachable on Windows. It was only in the native File menu, which Windows doesn't show. It's now in the title bar's Graph menu, and docs/investigations.md says so.
  • Release baselines added to docs/investigation-gates.md, from the manual validation of 2026-11-03. I checked the figures against that run's raw JSON, but didn't re-measure them.

Boundary check

Outside plugins/aws, AWS appears in host code only in test data, comments, the secret-shape check for access key IDs, and BUILTIN_PLUGINS, which ships the plugin in the app. An existing test stops the canvas and explorer naming AWS rules or labels.

Testing

  • cargo clippy --locked --workspace --all-targets -- -D warnings is clean, and cargo test --locked --workspace gives 356 passed, 0 failed, 1 ignored on Windows. CI will cover macOS.
  • A new unit test covers masking, including that bookkeeping properties stay.
  • In the real window on Windows: a node with a synthetic api_token shows [redacted] in the list with other properties intact, and Graph > Open investigation… opens the file picker. I cancelled the picker, so opening a file from it wasn't checked; khonsu open uses the same code after the picker.
  • The menu change has no automated test, and the window wasn't run on macOS.

Issue status

Refs #33, #34, #35, #36

🤖 Generated with Claude Code

…ion found

Manual validation on 2026-11-03 found two problems, neither specific to AWS:
- The inspector said a property was masked, then listed its value. The list
  now masks what evidence masks.
- Open investigation was only in the native File menu, which Windows doesn't
  show. It's now in the Graph menu too.

The exposure rules' document moves to plugins/aws/README.md, which also says the
plugin is an example with no new rules planned. Release baselines from the same
validation go in the gates document.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JetSquirrel
JetSquirrel merged commit f6cf0c2 into main Nov 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant