Repository navigation
Audit dashboard charts, and draw what the data says - #79
Merged
Merged
Conversation
A .dash file already carries its data paths relative to itself, but a whole investigation had nothing saying what it consisted of, or whether it would work on the machine it had just arrived on. An optional ducklocal-project.json lists the dashboards, any other data and the versions and extensions the work used. `project check` runs the existing check over each dashboard and adds what a move breaks: files that did not come along, paths that were never going to, extensions this machine lacks. Each problem says what to do next. It never reaches the network or installs anything: a dashboard reading remote data is left unrun, and says so. `limitations` says what passing does not cover, such as a source with the same name and different data. `project relink` points a source at where its file is now, keeping the old dashboard as a backup. Opening the manifest in the window opens its dashboards, and only those inside its folder, since one elsewhere would run SQL from somewhere nobody looked. A lone .dash file works as it always has. Closes #70. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Its cross join built up memory, so on a fast enough machine it reached the 2GB limit inside the 1s timeout and reported resource_limit, failing macOS CI. The limits were right; the query was testing the wrong one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
@codex Please implement the Dashboard quality audit in this draft PR, using You own the inspection, regression tests and focused fixes. Start by reading the existing dashboard/results-chart implementations and tests; do not reimplement features that already work.
Use Dynatrace Strato's chart guidance as a quality benchmark, not as code to copy. The maintainer will review the changes before merging. Please keep this PR as draft until findings and tests are ready. |
|
To use Codex here, create an environment for this repo. |
# Conflicts: # skills/ducklocal/references/cli.md # src/cli.rs # tests/cli.rs
Make an analysis folder portable, and say what a move broke
The audit in #79 found dashboard charts that misread their data. A line spaced one day and eight days alike, a NULL reading vanished under a line running across it, a pick on SQL NULL also caught the text 'NULL', and a pie drawn from a query cut short looked complete. Lines and scatters over times are now placed by time, and a dashboard line breaks at a NULL. A result records which cells hold the text NULL, so a pick selects only its own rows. Every dashboard chart says when its query was cut short, NaN and infinity stay out of averages, a series keeps its color while others come and go, and the series cap counts series. `open --state` adds each plot's `scope`, so an agent can read what the chart says. Area charts can't take time positions in the kit, so they say they're evenly spaced; that and the other gaps are in the findings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…261102' into fix/dashboard-fidelity
A map drew from a truncated result with nothing said, so its points could look like all of them. The results chart also let NaN and infinity into its buckets. The audit's specification now points at its findings and no longer names an owner that never ran. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JetSquirrel
marked this pull request as ready for review
November 2, 2026 16:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #64 and #65.
Why
A chart can mislead without being wrong about any one number. A line spaced one day and eight days alike, a NULL reading vanished under a line running across it, a pick on SQL NULL also caught the text
'NULL', and a pie drawn from a query cut short looked complete.The audit specified in
docs/dashboard-quality-audit.mdis done, with the results indocs/dashboard-quality-audit-findings.md. Codex never ran on this (the repo has no Codex environment), so this was done here instead.What
lineandscatterplaced by time, in dashboards and the results chartline'NULL'open --stategave source rows onlyscope: what it draws of its queryDecisions to review
lineover times draws in time order, whatever the query'sORDER BY. A row with a NULL time is left off, with a note.NULLnarrows further than before. The old match on both was deliberate, and a dashboard relying on it now gets one or the other.scopeis added besiderows, so the state schema version stays.Gaps
'NULL'as one band, and a card'stoneshown by color alone.Testing
cargo test --locked: 495 unit, 35 CLI, 8 LSP and 4 network-path tests pass, with 1 ignored. Fmt and clippy are clean.main, in a debug build. They don't use a time axis or NULL breaks, so those paths have no baseline.🤖 Generated with Claude Code