RG-2542 Updated RFC for table reorder API - #9352
Merged
Aleksei Berezkin (aleksei-berezkin) merged 2 commits intoJul 23, 2026
Merged
RG-2542 Updated RFC for table reorder API#9352Aleksei Berezkin (aleksei-berezkin) merged 2 commits into
Aleksei Berezkin (aleksei-berezkin) merged 2 commits into
Conversation
Aleksei Berezkin (aleksei-berezkin)
requested review from
Filipp Riabchun (Hypnosphi),
Andrey Skladchikov (andrey-skl) and
Copilot
July 21, 2026 11:21
Copilot started reviewing on behalf of
Aleksei Berezkin (aleksei-berezkin)
July 21, 2026 11:21
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Table component RFC to match the finalized reorder-related public API introduced in #9343, ensuring the documented callback signatures and behaviors reflect the actual implementation.
Changes:
- Updated column delete/reorder callback signatures to include the column being acted on.
- Documented item (row) reordering APIs (
canReorderItem,onItemReorder,noItemReorderAnimation) and expanded related prop docs. - Refined
Column.canReorderfunction signature to include reorder context (moved column + indices).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Andrey Skladchikov (andrey-skl)
approved these changes
Jul 23, 2026
Aleksei Berezkin (aleksei-berezkin)
deleted the
RG-2542-update-rfc-table-reorder
branch
July 23, 2026 07:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR syncs the table RFC with the actual API added in #9343 (
develop-8.0-table-reorder-item->develop-8.0)