Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2279.
JavaKoogHttpClient.ssecurrently decodes each non-comment line. Anevent:field reaches the payload decoder, multiline JSON arrives as separate chunks, and whitespace or incomplete trailing data changes the result.Accumulate
datafields until an empty line, preserve payload whitespace, remove one leading BOM, ignore metadata and comments, and discard incomplete events at EOF. Filtering and decoding receive complete data events. The parsing follows the WHATWG contract.This fix is already included in Kroog and is working in production applications using Kroog. This PR adapts the framing portion into a minimal patch. Original implementation by mrkim: d5ca5f6b2. Kroog also changes transport cancellation; this patch retains current transport handling, with lifetime and backpressure handled in #2285.
Validation: seven local HTTP server regression tests fail on the baseline and pass with this change. All 41 module JVM tests pass. Module
ktlintCheck,jarandgeneratePomFileForMavenPublicationpass; the compiled JVM ABI exactly matches the checked-in dump. No public signatures or dependencies change. The affected implementation is JVM only.Target:
develop.