Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2277.
Related to #504.
Add
OpenAIChatParams.withChatTemplateKwargs(JsonObject?)andchatTemplateKwargsfor provider-specific Chat Completions template controls. The existingadditionalPropertiesserialiser already supports the request field. The helper preserves other parameters and arbitrary JSON values, and null removes the configured arguments.This feature is already included in Kroog and is working in production applications using Kroog. Original implementation: ba7899a0e37df7d6cb7c9cf8d4fe777cd58983ed. This patch adapts the helper to Koog's existing serialiser. It omits Kroog's redundant request field and constructor validation for raw additional properties, preserving Koog's existing map behaviour.
No new dependencies. Two additive public members and a JVM API dump update; constructor and copy signatures are unchanged. Provider-specific values follow vLLM's documented dictionary extension.
Validation with Java 21: OpenAI client
jvmTestpassed all 211 tests;jvmJar,generatePomFileForJvmPublicationand both touched source-set ktlint checks passed. A reliable JVM-only ABI dump exactly matches the updated checked-in dump, with two additions and no removed descriptors. Four new tests cover map preservation, replacement and removal, nested JSON round trips, the outgoing HTTP request and omitted values. Live-provider and non-JVM checks are outside this JVM contribution scope.