Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RetryingLLMClientappends arbitrary exception messages to WARN output for ordinary retries and streaming failures before the first token. These messages can contain provider response bodies or credentials. Omit that text while retaining operation context, attempt counts and retry delay.Related issue: KG-377, Review logging.
This fix is already included in Kroog and is working in production applications using Kroog. This PR adapts that implementation into a minimal patch for Koog. Original implementation: a9b1ecdbfca6656b71ca54188fa29c9e27798326. Kroog uses structured retry metadata; this patch retains Koog's existing warning format and removes exception text from its two warning paths. It introduces no observer, classification or cancellation changes.
Two JVM regression tests capture SLF4J Simple output and verify that ordinary and streaming retries preserve useful context without disclosing synthetic credentials, response contents or exception causes. The backend already comes from
test-utils, so there are no new dependencies. These tests use local mock clients; production experience relates to Kroog.Validation on JDK 21:
./gradlew :prompt:prompt-executor:prompt-executor-clients:jvmTest :prompt:prompt-executor:prompt-executor-clients:jvmJar :prompt:prompt-executor:prompt-executor-clients:ktlintCheck :prompt:prompt-executor:prompt-executor-clients:generatePomFileForJvmPublication --max-workers=2passes. All 50 affected JVM tests pass, with no skips.api/jvm/prompt-executor-clients.apidump from the compiled JVM classes.git diff --checkpasses.No public API or ABI dump edits. JVM validation only; other platform tests and live-provider tests have not run.