Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RetryingLLMClientpropagates direct cancellation but can retry an exception that wraps it when the outer message matches a retryable error. A delegate throwingIllegalStateException("429 Too Many Requests", cancellation)is invoked three times withmaxAttempts = 3.Check the cause chain before retry handling and propagate the original
CancellationExceptionin both ordinary and streaming calls, including after the first frame. Bound traversal to 32 throwable nodes and stop on identity cycles. Cancellation deeper than that bound falls back to the existing handling of the outer exception.This fix is already included in Kroog and working in production applications using Kroog. This patch extracts the cancellation handling from a9b1ecdbf, using a dedicated traversal rather than the broader retry-classification helpers. No dependencies or public signatures change.
Validation: ordinary and streaming regressions fail before the fix, observing three attempts instead of one; the exact issue reproduction also fails before the fix. All 54 tests in the client module JVM suite pass with no skips, including direct and nested cancellation, non-retryable wrappers, streaming before and after a frame, cause cycles and the traversal boundary. JVM JAR, ktlint and publication metadata checks pass; the compiled JVM ABI matches the checked-in dump. These tests keep the caller active while the delegate throws wrapped cancellation. Repository-wide, non-JVM and live-provider tests were not run.
Closes #2273.