Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KtorKoogHttpClientdiscards ordinary request headers, so a request-specificAuthorizationvalue never reaches the server. Its factory also appends configured headers even when the request supplies a replacement.Apply headers directly to the request builder and use factory headers only when that header name is absent. Preserve explicit content types, unrelated defaults and defaults on subsequent requests.
These fixes are already included in Kroog and working in production applications using Kroog. This patch extracts the header corrections from 250069ec6 and f5580355c. No dependencies or public signatures change.
Validation: the two regression tests fail on unchanged develop. All 23 tests in the Ktor HTTP client module JVM suite pass, with no skips; the JVM JAR build and module ktlint checks pass. The compiled JVM ABI matches the checked-in dump, and public JVM descriptors are unchanged. New header-specific tests cover GET, POST and line streaming, including mixed-case overrides and subsequent requests. Existing SSE tests also pass; no new SSE header-specific test was added. The repository-wide suite and non-JVM targets were not run.
Closes #2269.