Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
discoverSkillscatches cancellation from directory listing and skill file reads, allowing traversal and caller code to continue after cancellation. RethrowCancellationExceptionat both catch sites while preserving the existing handling of ordinary I/O failures.Cancellation-safe discovery is already included and working in production applications through Kroog. Original implementation. Kroog uses narrow exception handling and explicit cancellation checks within a broader secure-session implementation. This patch adapts the exception-propagation behaviour to the existing discovery code. It does not add cooperative checks after a provider returns normally.
No dependencies or public signatures change. The regressions cancel real coroutines suspended in listing and reading, then check for later filesystem calls and caller continuation. Separate tests retain ordinary I/O failure skipping.
Validation: both cancellation regressions fail on unchanged develop; ordinary I/O failure tests pass. The complete skills module JVM suite passes all 22 tests, along with the JVM JAR build and module ktlint checks. A standalone reproduction fails on develop and passes with the fix. The repository-wide JVM suite and non-JVM targets were not run.
Closes #2267.