Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generateSkillsPrompt(YML)currently changes multiline strings through YAML folding and emits metadata keys that can parse as booleans, nulls or YAML syntax. Escape string values and quote unsafe keys so parsing preserves the original content. Ordinary identifier keys retain their existing layout.The underlying string-preservation fix is already included and working in production applications through Kroog. Original implementation. This patch adapts the key-quoting rules to the existing helpers, without importing the catalogue refactor or a runtime dependency. It also escapes YAML control characters that Kroog's JSON-based helper leaves raw; that additional coverage was validated locally.
Adds
org.snakeyaml:snakeyaml-engine:3.0.1tojvmTestdependencies inskills/build.gradle.kts. The regression tests use it to parse generated YAML and verify that every field and metadata key retains its original string value. This adds no production runtime dependency.Validation: 102 YAML parser round-trip cases using an explicit Core schema. The develop baseline fails 48; the same baseline with Kroog's extracted helpers fails four; this patch passes all 102. All 120 skills JVM tests, the JVM JAR build and module ktlint checks pass. No non-JVM tests were run.
Closes #2265.