Bringing Guice to live - #23
Open
Sergej Salnikov (SergejSalnikov) wants to merge 3 commits into
Open
Conversation
Yuriy Artamonov (jreznot)
requested a review
from Andrey Belyaev (belyaev-andrey)
June 20, 2026 08:45
Author
|
If you want to test it: gradle.properties: build.gradle.kts: import org.jetbrains.intellij.platform.gradle.TestFrameworkType
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
plugins {
id("java")
id("org.jetbrains.kotlin.jvm") version "2.3.0"
id("org.jetbrains.intellij.platform") version "2.16.0"
}
java {
toolchain {
languageVersion.set(JavaLanguageVersion.of(25))
}
}
group = "com.intellij.guice"
version = "261.0"
repositories {
mavenCentral()
intellijPlatform {
defaultRepositories()
}
}
dependencies {
intellijPlatform {
intellijIdea("2026.1")
bundledPlugin("com.intellij.java")
bundledPlugin("org.jetbrains.kotlin")
testFramework(TestFrameworkType.Platform)
testFramework(TestFrameworkType.Plugin.Java)
testFramework(TestFrameworkType.JUnit5)
}
testImplementation("com.google.truth:truth:1.4.2")
}
java {
sourceSets.getByName("main") {
java {
srcDir("gen")
srcDir("src")
}
kotlin {
srcDir("gen")
srcDir("src")
}
resources {
srcDir("resources")
}
}
sourceSets.getByName("test") {
java {
srcDir("test")
}
kotlin {
srcDir("test")
}
}
}
kotlin {
jvmToolchain(25)
}
intellijPlatform {
pluginConfiguration {
ideaVersion {
sinceBuild = "261"
}
changeNotes = ""
}
}
tasks {
// Set the JVM compatibility versions
withType<JavaCompile> {
options.release = 25
sourceCompatibility = "25"
targetCompatibility = "25"
}
withType<KotlinCompile> {
compilerOptions {
jvmTarget.set(JvmTarget.JVM_25)
}
}
} |
Author
|
Indentation seems to be off, but I don't know which code style is used at JetBrains and how to apply it to all files at once. Sorry. |
Author
Sergej Salnikov (SergejSalnikov)
marked this pull request as draft
June 22, 2026 10:08
Sergej Salnikov (SergejSalnikov)
marked this pull request as ready for review
June 25, 2026 12:35
Author
|
Andrey Belyaev (@belyaev-andrey), do you want to take a look? :) |
Andrey Belyaev (belyaev-andrey)
requested review from
Yann Cébron (YannCebron) and
Daniil Tsarev (dtsaryov)
July 1, 2026 17:42
|
bump! |
|
Is there a |
Author
|
have you tried the PR? maybe it doesn't work at all :). |
Author
Works great with Kotlin: using java 21, gradle 8, kotlin 2. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete refactoring of Guice binding and injection site analysis.
Added kotlin language support
Added many Guice features as Multibinders and etc.
Performance optimizations
Added unit tests