Skip to content

[codex] Promote green Linux socket candidates - #275

Merged
Jesssullivan merged 2 commits into
mainfrom
codex/tin183-promote-socket-candidates
Apr 29, 2026
Merged

[codex] Promote green Linux socket candidates#275
Jesssullivan merged 2 commits into
mainfrom
codex/tin183-promote-socket-candidates

Conversation

@Jesssullivan

@Jesssullivan Jesssullivan commented Apr 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • move the ten repeatedly green phase-1 Linux socket tests into the hard baseline
  • leave test_sprint_b_core_parity as the only non-fatal candidate for the known Linux remote-workspace parity gap
  • update program/readiness docs from 18 baseline + 11 candidates to 28 baseline + 1 candidate

Validation

  • bash -n scripts/run-socket-tests.sh
  • git diff --check

Linear

  • TIN-183

@Jesssullivan
Jesssullivan marked this pull request as ready for review April 29, 2026 01:22
@greptile-apps

greptile-apps Bot commented Apr 29, 2026

Copy link
Copy Markdown

Greptile Summary

Promotes 10 repeatedly-green phase-1 Linux socket tests into the hard baseline (18→28), shrinks CANDIDATES_PHASE1 to a single entry (test_sprint_b_core_parity), and syncs both readiness-plan and program-status docs to the new counts. All three files are internally consistent and the script logic is unchanged.

Confidence Score: 5/5

Safe to merge — purely additive allowlist promotion with matching doc updates and no logic changes.

All changes are mechanical: moving test names between two bash arrays and updating integer counts in two markdown files. The numbers are consistent (28 BASELINE entries match the declared count; 1 CANDIDATES_PHASE1 entry matches). No control-flow, no new code paths, and no risk of regressions.

No files require special attention.

Important Files Changed

Filename Overview
scripts/run-socket-tests.sh Promotes 10 tests from CANDIDATES_PHASE1 to BASELINE (18→28) and shrinks the candidate list to a single entry (test_sprint_b_core_parity); logic and counts are consistent.
docs/program-status.md Updates counts (18→28 baseline, 11→1 candidate) and removes the now-resolved warning about test_surface_action_close_variants; doc matches script state.
docs/distro-testing-readiness-plan.md Updates counts and near-term target language to reflect that the promotion has occurred; consistent with the script and program-status changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[tests_v2/*.py — 123 files on disk] --> B{run-socket-tests.sh}
    B --> C[BASELINE — 28 tests\nfailure fails the job]
    B --> D{CMUX_TEST_PHASE1=1?}
    D -- yes --> E[CANDIDATES_PHASE1 — 1 test\ntest_sprint_b_core_parity\nnon-fatal]
    D -- no --> F[Skip candidates]
    C --> G[TAP result + exit code]
    E --> G
    G -->|FAIL > 0| H[exit 1]
    G -->|FAIL = 0| I[exit 0]
Loading

Reviews (1): Last reviewed commit: "Merge branch 'main' into codex/tin183-pr..." | Re-trigger Greptile

@Jesssullivan
Jesssullivan merged commit be7619b into main Apr 29, 2026
10 checks passed
@Jesssullivan
Jesssullivan deleted the codex/tin183-promote-socket-candidates branch April 29, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant