[codex] Use baseline CPU for Linux release builds - #273
Conversation
Greptile SummaryThis PR replaces Zig's Confidence Score: 5/5Safe to merge — the change is mechanically correct, complete, and well-validated by the PR description. The substitution of No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[GHA matrix: ubuntu-latest / ubuntu-24.04-arm] --> B[Build vendor libraries\nzig build -Dcpu=baseline -Doptimize=ReleaseFast]
B --> C[Build libghostty\nzig build -Dcpu=baseline ...]
C --> D[Build cmux-linux\nzig build -Dcpu=baseline ...]
D --> E[Build cmuxd\nzig build -Dcpu=baseline ...]
E --> F[Assemble DEB / RPM package]
F --> G[Smoke test on distro VM]
Reviews (1): Last reviewed commit: "Use baseline CPU for Linux release build..." | Re-trigger Greptile |
Summary
Supersedes the
-Dtarget=...release-build approach from PR #272 with-Dcpu=baseline.Why
Release run
25082497926showed that explicit-Dtarget=x86_64-linux-gnumakes the vendor library builds behave like cross-builds and stop finding distro system libraries via pkg-config/system paths:unable to find dynamic system library 'secret-1'unable to find dynamic system library 'gio-2.0'unable to find dynamic system library 'gobject-2.0'unable to find dynamic system library 'glib-2.0'We still need to avoid native runner CPU features in release artifacts because the Fedora VM smoke test previously showed
Illegal instructionfor bothcmux --versionandcmux --help.-Dcpu=baselineis the narrower fix: it keeps native OS/ABI and system library resolution, while preventing Zig from emitting instructions for the builder CPU.Changes
-Dtarget=${{ matrix.arch.zig }}with-Dcpu=baseline.zigtarget fields.The stricter distro VM smoke test and Rocky sed delimiter fix remain from #272.
Validation
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release-linux.yml"); puts "release-linux.yml parses"'nix-instantiate --parse nix/tests-distro.nixgit diff --checkRelease run
25082497926was cancelled after the-Dtargetvendor-link failure was confirmed.