Relax short activity card validation#333
Open
Laksh-star wants to merge 1 commit into
Open
Conversation
Laksh-star
marked this pull request as ready for review
July 22, 2026 00:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relax activity-card duration validation so short transition cards do not fail an otherwise usable timeline batch.
Why
Some providers occasionally return coherent short transition cards in the middle of a capture window. Previously, cards under 10 minutes caused the entire batch to fail, even when the generated timeline was otherwise useful. This could create unnecessary "Processing failed" cards and force manual retry.
Changes
Validation
xcodebuild test -project Dayflow/Dayflow.xcodeproj -scheme Dayflow -destination 'platform=macOS' -derivedDataPath DerivedDataUpstreamPR CODE_SIGNING_ALLOWED=NO -only-testing:DayflowTestsNote: a full local test run reached unit tests but hit an unrelated
DayflowUITests-Runnerbootstrap crash.