test: wire repo-root DayflowTests into the compiled DayflowTests target#310
Open
praxstack wants to merge 1 commit into
Open
test: wire repo-root DayflowTests into the compiled DayflowTests target#310praxstack wants to merge 1 commit into
praxstack wants to merge 1 commit into
Conversation
DayflowTests/ChatCLIProcessRunnerTests.swift and DailyRecapGeneratorTests.swift lived at the repo root, outside the Xcode project's DayflowTests target (which only wires Dayflow/DayflowTests/ via a PBXFileSystemSynchronizedRootGroup). They were never compiled or run. Moving them in immediately caught a live compile bug — proof they were never running: testMakeLocalPromptPlacesLanguageSectionBeforeOutputFormat() called `try XCTUnwrap` but was missing `throws` on its signature. Fixed with one line. All 11 tests (6 pre-existing + 5 newly-wired) now pass: xcodebuild -scheme Dayflow -destination 'platform=macOS' test ** TEST SUCCEEDED **
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
DayflowTests/ChatCLIProcessRunnerTests.swiftandDailyRecapGeneratorTests.swiftlived at the repo root — outside the Xcode project'sDayflowTeststarget, which only wiresDayflow/DayflowTests/(viaPBXFileSystemSynchronizedRootGroup). they were never compiled or run.moved both into
Dayflow/DayflowTests/(git mv, no.pbxprojedit needed since it's a synced group).bonus: caught a real bug
moving them in immediately hit a compile error — proof these tests genuinely never ran:
testMakeLocalPromptPlacesLanguageSectionBeforeOutputFormat()was missingthrowsdespite callingtry XCTUnwrapinside. one-line fix.tests
all 11 tests pass (6 pre-existing + 5 newly-wired:
ChatCLIProcessRunnerTestsx6,DailyRecapGeneratorTestsx5).note:
DayflowUITests-Runnerfails to load its bundle on this run — confirmed viagit stashthat this is pre-existing on unmodifiedmain, unrelated to this change.Follow-up hardening pass (2026-07-08)
Ran an internal hardening pass (independent fresh-context code review + full re-verification) — no additional issues found.
ChatCLIProcessRunner,DailyRecapGenerator.makeLocalPrompt,DailyRecapSourceDayResolver,DayflowDailyGenerationRequest) — no mocks, no tautological assertions.throwsaddition is genuinely required (4xtry XCTUnwrapin the body), proving the test had never compiled before this PR.** BUILD SUCCEEDED **.** TEST SUCCEEDED **— 17/17 unit tests pass (ChatCLIProcessRunnerTests6,DailyRecapGeneratorTests5,WeeklyDashboardBuilderTests3,TimeParsingTests2,ProvidersSettingsViewModelTests1); all 6 pre-existing tests unaffected.Follow-up hardening pass (2026-07-08)
Re-verified: this is a pure test-target-wiring change with no production logic, so there is nothing to add edge-case tests to — but I confirmed all 11 now-compiled tests run green (6 pre-existing + 5 newly-wired: ChatCLIProcessRunnerTests x6, DailyRecapGeneratorTests x5). No defects found.