fix(ci): release bump 안전장치 추가 - #71
Merged
Merged
Conversation
JeremyDev87
marked this pull request as ready for review
April 24, 2026 12:31
Owner
Author
|
독립 fresh-session 리뷰 결과
|
JeremyDev87
force-pushed
the
codex/release-soft-landing
branch
6 times, most recently
from
April 24, 2026 13:48
2a5c1d3 to
6e8ed27
Compare
JeremyDev87
force-pushed
the
codex/release-soft-landing
branch
from
April 24, 2026 13:52
6e8ed27 to
4f030a2
Compare
Owner
Author
|
독립 fresh-session 리뷰 결과
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
Kratos release에서 확인한 실패 패턴을 Maximus release 경로에 반영합니다. 핵심은 version bump PR 생성, candidate commit 검증, tag publish 사이를 명확히 분리하는 것입니다.
변경 사항
manual-release-bump.yml을 추가해 version-only bump branch/PR을 만들고 PR 생성 실패를 hard fail로 처리합니다.release-candidate.yml을 추가해 tag 생성 전 exact candidate SHA를 검증합니다.검증
git diff --checkactionlint .github/workflows/manual-release-bump.yml .github/workflows/release-candidate.yml .github/workflows/release.yml .github/workflows/dev.ymlnode --test test/release-workflow-context.test.js test/github-action-wiring.test.js test/release-plan.test.js test/npm-error-classifiers.test.js test/bump-release-version.test.jsnode ./scripts/validate-rust-release-wiring.mjscargo test --workspacenode ./scripts/run-packed-wrapper-smoke.mjs /tmp/maximus-release-pack/root-pack.json test/fixtures/clean-project참고
npm test는 기존wrapper accepts execute-only installed runtime binaries1건이 실패합니다. 이번 변경 파일과 무관한 기존 wrapper runtime 테스트이며, release candidate에 직접 필요한 packed wrapper smoke는 별도로 통과했습니다.