Skip to content

[codex] Rust workspace bootstrap 추가 - #3

Merged
JeremyDev87 merged 1 commit into
masterfrom
codex/rust-workspace-bootstrap
Apr 17, 2026
Merged

[codex] Rust workspace bootstrap 추가#3
JeremyDev87 merged 1 commit into
masterfrom
codex/rust-workspace-bootstrap

Conversation

@JeremyDev87

Copy link
Copy Markdown
Owner

배경

TODO.md의 Rust rewrite 우선순위에 따라 P063-A를 먼저 진행했습니다. 이번 PR은 Maximus의 Rust 전환을 위한 첫 bootstrap 단계로, Cargo workspace와 최소 crate 골격을 세우고 CI에서 workspace metadata를 검증할 수 있게 만드는 작업입니다.

변경 사항

  • 루트에 Cargo.tomlrust-toolchain.toml을 추가해 Rust stable workspace 기준을 만들었습니다.
  • crates/maximus-cli, crates/maximus-core, crates/maximus-checks 3개 crate의 최소 manifest와 stub source를 추가했습니다.
  • 기존 Node 검증 lane은 유지한 채 .github/workflows/dev.yml에 Rust metadata 검증 job을 추가했습니다.
  • CI path filter에 Rust bootstrap 파일들(Cargo.toml, rust-toolchain.toml, crates/**)을 포함했습니다.
  • 새 Rust setup 액션은 기존 workflow 스타일에 맞춰 commit SHA로 pin 했습니다.

검증

  • cargo metadata --format-version 1 --no-deps
  • npm test
  • node ./bin/maximus.js audit ./test/fixtures/clean-project

리스크 또는 후속 확인 포인트

  • 이번 PR은 bootstrap 단계만 다루므로 실제 Rust 로직 포팅이나 parity 구현은 아직 없습니다.
  • 다음 단계인 P063-B에서 JS reference golden artifact를 고정하고, P063-C에서 core pure library 계층을 옮겨갈 예정입니다.

@JeremyDev87 JeremyDev87 self-assigned this Apr 17, 2026
@JeremyDev87
JeremyDev87 marked this pull request as ready for review April 17, 2026 17:33
@JeremyDev87

Copy link
Copy Markdown
Owner Author

Independent fresh-session review result

  • Verdict: CHANGE_REQUEST
  • Findings:
    • Medium: The Rust bootstrap does not yet define a Cargo.lock / target/ repository policy, and .github/workflows/dev.yml does not watch Cargo.lock, so a normal Rust command can leave the repo dirty and lockfile-only updates could skip the Rust metadata lane. Files: Cargo.toml, .gitignore, .github/workflows/dev.yml.
  • Rationale: The workspace manifests and metadata job are otherwise sound, but this bootstrap still leaves reproducibility and worktree hygiene underspecified.

Note: This result is posted as a PR comment because GitHub does not allow an author to submit an official request-changes review on their own pull request.

@JeremyDev87
JeremyDev87 force-pushed the codex/rust-workspace-bootstrap branch from d64ce83 to b3cb28e Compare April 17, 2026 17:38
@JeremyDev87

Copy link
Copy Markdown
Owner Author

Independent fresh-session review result

  • Verdict: APPROVE
  • Findings: none
  • Rationale: The Cargo workspace is internally consistent, the CI path filters include the new Rust files, and local cargo metadata --no-deps plus cargo check --workspace both pass cleanly.

Note: This result is posted as a PR comment because GitHub does not allow an author to submit an official approve review on their own pull request.

@JeremyDev87
JeremyDev87 merged commit 5922ede into master Apr 17, 2026
18 checks passed
@JeremyDev87
JeremyDev87 deleted the codex/rust-workspace-bootstrap branch April 17, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant