fix(tsconfig): Next 생성 타입 include 경고 완화 - #101
Merged
Merged
Conversation
Next 패키지에서 .next/types/**/*.ts include가 비어 있을 때 warning 대신 info로 보고하도록 조정한다. Rust/CLI 회귀 테스트로 Next info-only exit 0과 일반 프로젝트 warning 유지 계약을 검증한다. Closes #100
Owner
Author
|
독립 fresh-session 리뷰 결과
검증 근거:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
Next.js 프로젝트의 기본
tsconfig.json에는.next/types/**/*.tsinclude가 들어갈 수 있습니다. clean checkout이나 build 전 상태에서는.next가 아직 없어 Maximus가 warning을 내고 exit status를 1로 만들 수 있었습니다.변경 사항
.next/types/**/*.ts/./.next/types/**/*.ts빈 include를Info로 낮췄습니다.package.json의dependencies,devDependencies,peerDependencies,optionalDependencies에서next존재 여부를 확인합니다.Warn과 generic hint를 유지합니다.Info계약은 변경하지 않았습니다.검증
rustfmt --check crates/maximus-checks/src/tsconfig.rs crates/maximus-checks/tests/tsconfig_checks.rscargo test -p maximus-checks --test tsconfig_checksnode --test test/tsconfig-patterns-cli.test.jsnode --test test/reference-parity.test.jsgit diff --checkcargo test --workspacenpm test두 번 연속 통과첫
npm test전체 실행에서 기존 allowJs assertion이 한 번 transient 실패했지만, 같은 파일 단독 재실행과 이후 전체npm test2회가 모두 통과했습니다.브랜치 / 워크트리
codex/fix-100-next-types-info/private/tmp/maximus-pr100-next-types-infomaster이슈 연결
Closes #100