feat(core): duplicate 영향 범위와 리포트 요약 모델 추가 - #83
Merged
Conversation
npm lockfile duplicate의 production/dev/unknown 범위를 모델에 추가하고 dev-only/unknown duplicate를 초기 페이로드 절감 추정에서 제외합니다. Closes #78
Owner
Author
|
독립 fresh-session 리뷰 결과
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
#78은 lockfile duplicate가 실제 초기 페이로드 개선인지 dev/test hygiene인지 구분할 수 있도록 core 모델과 계산 계약을 추가하는 작업입니다.
변경 사항
DuplicatePackage에 additiveimpactScope를 추가했습니다.packages[*].dev기반으로production-likely,dev-only,unknown범위를 판정합니다.ReportSummary모델과 생성 함수를 추가했습니다.검증
git diff --checkcargo fmt --all --checkcargo test -p legolas-core --test lockfilescargo test -p legolas-core --test intelligence_impactcargo test -p legolas-core --test duplicate_origin_tracecargo test -p legolas-cli --test json_schema_contract scan_json_matches_analysis_schema_doccargo test -p legolas-cli --test cli_contract matches_scan_visualize_and_optimize_oraclescargo test -p legolas-cli --test budget_contractcargo test -p legolas-cli --test ci_contract ci_json_output_uses_machine_readable_gate_shapecargo test -p legolas-corecargo test --workspacecargo clippy --workspace --all-targets -- -D warnings리뷰 게이트
브랜치 / 워크트리
codex/feat-78-core-report-summary/tmp/legolas-wave1/issue-78-core-report-summaryCloses #78