feat: finding confidence label 추가 - #21
Merged
Merged
Conversation
Owner
Author
|
독립 fresh-session 리뷰 결과
참고: PR 작성자와 리뷰 계정이 같아 GitHub policy상 official approve 대신 PR comment로 남깁니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
confidence(high/medium/low)를 추가해 core 분석 결과의 신호 강도를 명시합니다.변경 사항
FindingMetadata에 optionalconfidence필드를 추가하고 기존 JSON 역직렬화 호환성을 유지했습니다.crates/legolas-core/src/confidence.rs를 추가해 heavy dependency, duplicate package, lazy-load candidate, tree-shaking warning의 공통 scoring helper를 도입했습니다.analyze.rs와import_scanner.rs에서 finding confidence를 채우고 tree-shaking warning merge 시 가장 강한 confidence를 유지하도록 정리했습니다.tests/oracles/basic-app/scan.jsonparity oracle을 갱신했습니다.검증
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace[$devils-advocate-review-loop](/Users/pjw/.codex/skills/devils-advocate-review-loop/SKILL.md)Round 1 결과: Critical/High 0건브랜치 / 워크트리
mastercodex/fit-confidence-labels/Users/pjw/workspace/legolas이슈 연결