Skip to content

feat: finding confidence label 추가 - #21

Merged
JeremyDev87 merged 1 commit into
masterfrom
codex/fit-confidence-labels
Apr 19, 2026
Merged

feat: finding confidence label 추가#21
JeremyDev87 merged 1 commit into
masterfrom
codex/fit-confidence-labels

Conversation

@JeremyDev87

Copy link
Copy Markdown
Owner

배경

  • finding metadata에 confidence(high/medium/low)를 추가해 core 분석 결과의 신호 강도를 명시합니다.

변경 사항

  • FindingMetadata에 optional confidence 필드를 추가하고 기존 JSON 역직렬화 호환성을 유지했습니다.
  • crates/legolas-core/src/confidence.rs를 추가해 heavy dependency, duplicate package, lazy-load candidate, tree-shaking warning의 공통 scoring helper를 도입했습니다.
  • analyze.rsimport_scanner.rs에서 finding confidence를 채우고 tree-shaking warning merge 시 가장 강한 confidence를 유지하도록 정리했습니다.
  • confidence fixture/test를 추가하고 tests/oracles/basic-app/scan.json parity oracle을 갱신했습니다.

검증

  • cargo fmt --all --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace
  • [$devils-advocate-review-loop](/Users/pjw/.codex/skills/devils-advocate-review-loop/SKILL.md) Round 1 결과: Critical/High 0건

브랜치 / 워크트리

  • base: master
  • head: codex/fit-confidence-labels
  • current worktree: /Users/pjw/workspace/legolas
  • source branches/worktrees: 없음

이슈 연결

  • 없음

@JeremyDev87

Copy link
Copy Markdown
Owner Author

독립 fresh-session 리뷰 결과

  • Verdict: APPROVE
  • Findings: 없음
  • Rationale: core confidence labeling 변경이 finding metadata, analyzer, tree-shaking merge, parity oracle에 일관되게 반영되어 있고, 로컬 merge-gate와 핵심 타깃 테스트가 모두 통과했습니다.

참고: PR 작성자와 리뷰 계정이 같아 GitHub policy상 official approve 대신 PR comment로 남깁니다.

@JeremyDev87 JeremyDev87 self-assigned this Apr 19, 2026
@JeremyDev87
JeremyDev87 marked this pull request as ready for review April 19, 2026 15:15
@JeremyDev87
JeremyDev87 merged commit 62ae52e into master Apr 19, 2026
7 checks passed
@JeremyDev87
JeremyDev87 deleted the codex/fit-confidence-labels branch April 19, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant