feat: finding evidence 메타데이터 채우기 - #20
Merged
Merged
Conversation
Owner
Author
|
독립 fresh-session 리뷰 결과
참고: GitHub 정책상 self-authored PR에는 공식 approve review를 제출할 수 없어 동일한 verdict를 PR comment로 남깁니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
PR-FIT-001B범위에서 core analysis finding에 structured evidence를 실제로 채우는 작업이 필요했습니다.heavy dependency,lazy-load candidate,tree-shaking warning결과에findingId,analysisSource,evidence가 비어 있었습니다.변경 사항
crates/legolas-core/src/analyze.rscrates/legolas-core/src/import_scanner.rscrates/legolas-core/tests/finding_evidence.rstests/fixtures/findings/evidence-app/*tests/oracles/basic-app/scan.jsonfindingId,analysisSource,evidence를 반영했습니다.검증
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspacecargo test -p legolas-core --test finding_evidence --test analyze_parityDashboard.tsx와src/utils/shared.ts가 함께chart.js를 import하는 임시 프로젝트에서scan --json실행src/Dashboard.tsx만 포함하는 것 확인브랜치 / 워크트리
codex/fit-finding-evidencemaster/Users/pjw/workspace/legolas리뷰 루프
APPROVEAPPROVE0