refactor: 레거시 JS 구현과 Node 테스트 제거 - #12
Merged
Merged
Conversation
Owner
Author
|
독립 fresh-session 리뷰 결과
참고: 작성자 본인 PR이라 GitHub 정책상 공식 approve review 대신 PR comment로 남깁니다. |
JeremyDev87
force-pushed
the
codex/rust-js-retirement
branch
from
April 19, 2026 00:21
ffea8cf to
106ebc4
Compare
JeremyDev87
marked this pull request as ready for review
April 19, 2026 00:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
package_intelligence/impactparity 검증도 삭제 예정인 JS source를 직접 읽고 있어서, 마지막 retirement 단계 전에 snapshot 기반으로 옮길 필요가 있었습니다.변경 사항
src/아래 레거시 JS business logic와test/cli.test.js,test/analyze-project.test.js,test-support/parity-oracles.js를 제거했습니다.tests/oracles/package-intelligence/registry.json,tests/oracles/impact/cases.jsonsnapshot을 읽도록 바꿨습니다.scripts/generate-rust-parity-fixtures.mjs가 cargo run 반복 호출 대신 Rust CLI binary를 build 후 직접 실행하도록 정리했습니다.CONTRIBUTING.md의 현재 repo shape와 contributor 경로를 JS retirement 이후 상태에 맞게 갱신했습니다.검증
cargo test --workspacenode --test test/launcher-platform.test.jsnode ./scripts/generate-rust-parity-fixtures.mjsnpm run smokenpm run pack:checknpm pack --dry-run --json --cache ./.npm-cachenode ./bin/legolas.js --versionnode ./bin/legolas.js scan tests/fixtures/parity/basic-app브랜치 / 워크트리
mastercodex/rust-js-retirement/private/tmp/legolas-rust-js-retirement이슈 연결