feat: npm launcher를 Rust binary로 전환 - #11
Merged
Merged
Conversation
Owner
Author
|
독립 fresh-session 리뷰 결과
참고: 작성자와 리뷰 계정이 같아 GitHub 정책상 공식 request-changes review 대신 PR comment로 남깁니다. |
JeremyDev87
force-pushed
the
codex/rust-npm-cutover
branch
from
April 18, 2026 16:16
7472baf to
a2d5105
Compare
Owner
Author
|
독립 fresh-session 리뷰 결과
참고: 작성자와 리뷰 계정이 같아 GitHub 정책상 공식 approve review 대신 PR comment로 남깁니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
vendor/<triple>/legolas[.exe]를 실행하는 thin launcher로 전환했습니다.package.json,scripts/check-pack.mjs, CI/release workflow를 Rust vendor 배포 모델에 맞게 정리했습니다.npx사용자 경로와cargo기반 contributor 경로로 분리해 현재 배포 방식과 맞췄습니다.검증
cargo test --workspacenpm testnpm run smokenode ./scripts/stage-local-vendor-binary.mjsnode ./scripts/verify-vendor-layout.mjsnode ./bin/legolas.js --versionnode ./bin/legolas.js helpnode ./bin/legolas.js scan tests/fixtures/parity/basic-appnpm run pack:checknpm pack --dry-run --json --cache ./.npm-cache메모
legolas: no packaged Rust binary for <platform>/<arch>로 실패하도록 고정했습니다.