fix(review): 머지 감지 시 리뷰를 즉시 중단 - #453
Open
JeremyDev87 wants to merge 2 commits into
Open
Conversation
리뷰 도중 PR lifecycle이 MERGED로 바뀌면 추가 검사, 수정, push, GitHub 게시를 중단합니다. 두 runtime projection과 brief/output 계약에 동일한 sentinel을 연결하고 회귀 검증을 추가했습니다.
merge stop 규칙의 중복 설명을 reference로 모으고 hot path를 압축해 모든 subcommand token budget admission을 통과시킵니다.
Owner
Author
ddalggak review — approveLifecycle: |
JeremyDev87
marked this pull request as ready for review
September 1, 2026 06:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
review실행 중 PR lifecycle을 intake, 위임/장시간 작업 후, 모든 수정·push·GitHub 게시 직전에 재확인합니다.state=MERGED또는mergedAt감지 시REVIEW_STOPPED_PR_MERGED를 기록하고 추가 검사·위임·수정·push·리뷰/댓글 게시를 중단합니다.Why
리뷰 도중 이미 머지된 PR에 뒤늦은 findings, 수정, 또는 GitHub write가 이어지는 것을 막고 lifecycle 변경을 fail-closed로 처리하기 위함입니다.
Validation
npm run test:conditional-command-assets— PASSnpm run test:review-contract— PASSnpm run verify:projections— PASSnpm run verify:codex-skill— PASSnpm run verify:hermes-skill— PASSgit diff --check— PASSnpm run verify— checkout 상위 경로의 공백을 URL encoding한 기존 ULW parity runner 문제로 BLOCKED (SOURCE.json경로를%20포함 문자열로 해석). 변경 범위의 focused gate는 모두 통과했습니다.Risk
BLOCKED로 처리하므로 잘못된 추가 write보다 중단을 우선합니다.Issues