Expand unit tests to improve code coverage for options - #240
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
johnslavik
reviewed
Jul 25, 2025
Ja-Gk-00
changed the title
adanilenka
reviewed
Jul 30, 2025
adanilenka
reviewed
Jul 30, 2025
adanilenka
reviewed
Jul 30, 2025
| (jelly.PHYSICAL_STREAM_TYPE_QUADS, jelly.LOGICAL_STREAM_TYPE_FLAT_QUADS), | ||
| (jelly.PHYSICAL_STREAM_TYPE_QUADS, jelly.LOGICAL_STREAM_TYPE_DATASETS), | ||
| (jelly.PHYSICAL_STREAM_TYPE_QUADS, jelly.LOGICAL_STREAM_TYPE_NAMED_GRAPHS), | ||
| (jelly.PHYSICAL_STREAM_TYPE_TRIPLES, jelly.LOGICAL_STREAM_TYPE_FLAT_TRIPLES), |
Collaborator
There was a problem hiding this comment.
isn't it the first option in the list? Oo
Contributor
Author
There was a problem hiding this comment.
Oh, yes. Eh my IDE is not really helpful in showing duplicates. Fixed.
adanilenka
reviewed
Jul 30, 2025
| - "docs" | ||
| - "tests" | ||
| - "examples" | ||
| - "jelly" No newline at end of file |
Collaborator
There was a problem hiding this comment.
so this makes protobuf files ignored, do we really want to do that?
Contributor
Author
There was a problem hiding this comment.
Yes it will and that was my point. Mainly, I've read about testing code, and in general generated code is not really tested (at least not directly like here) and we should make some integration/conformance test for that that would check its viability. So ok, for this PR will still include it, however i think we should make a patch to exclude it.
adanilenka
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests for options to expand the overall test coverage.
Also excluded file rdf_pb2.py from codecov coverage (its automatically generated code and uncovered parts are not used).