Skip to content

Fix Recording Date Serialization Test #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spottedmahn wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Recording Date Serialization Test #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcc5c2a
Fix Recording Date Serialzation
Nov 26, 2019
75e0215
Fix Serialization Test
Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions test/Id3.Net.Tests/SerializationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,11 @@ limitations under the License.
*/
#endregion

using Id3.Frames;
using Id3.Serialization;
using System;
using System.IO;
using System.Runtime.Serialization.Formatters.Binary;
using Id3.Frames;
using Id3.Serialization;

using Xunit;

namespace Id3.Net.Tests
Expand All @@ -32,7 +31,8 @@ public sealed class SerializationTests
[Fact]
public void Serialize_deserialize_test()
{
var tag = new Id3Tag {
var tag = new Id3Tag
{
Title = "There Will Never Be Another Tonight",
Album = "Waking up the neighbors",
Track = new TrackFrame(9, 15),
Expand Down Expand Up @@ -66,7 +66,11 @@ public void Serialize_deserialize_test()
Assert.Equal(tag.Year.Value, clonedTag.Year.Value);
Assert.Equal(tag.Genre.Value, clonedTag.Genre.Value);
Assert.Equal(tag.Publisher.Value, clonedTag.Publisher.Value);
Assert.Equal(tag.RecordingDate.Value, clonedTag.RecordingDate.Value);

//https://github.com/JeevanJames/Id3/pull/27#issuecomment-565815805
//TDAT is only day and month
Assert.Equal(tag.RecordingDate.Value.Value.Month, clonedTag.RecordingDate.Value.Value.Month);
Assert.Equal(tag.RecordingDate.Value.Value.Day, clonedTag.RecordingDate.Value.Value.Day);

Assert.Equal(tag.Artists.Value.Count, clonedTag.Artists.Value.Count);
for (var i = 0; i < tag.Artists.Value.Count; i++)
Expand Down