fix(save): offer checksum correction when overwriting a file - #3
Open
mael-chouteau wants to merge 1 commit into
Open
fix(save): offer checksum correction when overwriting a file#3mael-chouteau wants to merge 1 commit into
mael-chouteau wants to merge 1 commit into
Conversation
Previously ChecksumHelper.correct() ran only for new save paths; saving over an existing file skipped the checksum prompt entirely after the overwrite confirmation. Unify the flow: after optional overwrite approval, always prompt for checksum correction before write. Fixes JeanLucPons#2 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When saving,
ChecksumHelper.correct()was only offered if the output path did not already exist. Saving over an existing file asked for overwrite confirmation but never prompted for checksum correction, so the written file could still have stale MCS32 / RSA+MD5 / SCS32 values.Change
Unify the save path: after optional overwrite approval, always offer the same "Do you want to correct the checksum?" dialog and call
ChecksumHelper.correct(dump.memory)when the user chooses Yes.Related
Closes #2 (issue describing this behavior).
Made with Cursor