Skip to content

Reconnect if multiple CoAP PDUs go unanswered #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roysjosh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reconnect if multiple CoAP PDUs go unanswered #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions aiohomekit/controller/coap/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ class EncryptionContext:

coap_ctx: Context
lock: asyncio.Lock
timeouts: int
uri: str

event_ctr: int
Expand All @@ -88,6 +89,7 @@ def __init__(self, recv_ctx, send_ctx, event_ctx, uri, coap_ctx):

self.coap_ctx = coap_ctx
self.lock = asyncio.Lock()
self.timeouts = 0
self.uri = uri

def decrypt(self, enc_data: bytes) -> bytes:
Expand Down Expand Up @@ -167,12 +169,17 @@ async def post_bytes(self, payload: bytes, timeout: int = 16.0):
request = Message(code=Code.POST, payload=payload, uri=self.uri)
async with asyncio_timeout(timeout):
response = await self.coap_ctx.request(request).response
except (NetworkError, asyncio.TimeoutError):
except (NetworkError, asyncio.TimeoutError) as e:
self.send_ctr -= 1
self.timeouts += 1
logger.debug(f"Network error or timeout: {e}")
raise AccessoryDisconnectedError("Request timeout")

if response.code != Code.CHANGED:
logger.warning(f"CoAP POST returned unexpected code {response}")

self.timeouts = 0

return await self._decrypt_response(response)

async def post(
Expand Down Expand Up @@ -396,7 +403,11 @@ async def connect(self, pairing_data):

@property
def is_connected(self):
return self.enc_ctx is not None and self.enc_ctx.coap_ctx is not None
return (
self.enc_ctx is not None
and self.enc_ctx.coap_ctx is not None
and self.enc_ctx.timeouts < 3
)

async def get_accessory_info(self):
_, body = await self.enc_ctx.post(OpCode.UNK_09_READ_GATT, 0x0000, b"")
Expand Down