Skip to content

Only use external provider urls#186

Merged
Eeems merged 9 commits into
mainfrom
Eeems-patch-2
Jun 23, 2026
Merged

Only use external provider urls#186
Eeems merged 9 commits into
mainfrom
Eeems-patch-2

Conversation

@Eeems

@Eeems Eeems commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features
    • Download system now supports multiple external provider sources with automatic fallback to improve reliability across versions.
    • Expanded provider URL configuration to cover additional Omaha download locations for rm1 and rm2.
  • Build & CI
    • Updated development download commands to enable verbose output for easier troubleshooting.
    • Disabled the device testing step in the main workflow, so the release pipeline no longer waits for device testing.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

download_version in UpdateManager is refactored to drop direct BASE_URL/BASE_URL_V3 construction and instead iterate all external_provider_urls, substituting both REPLACE_ID and REPLACE_NAME placeholders. data/version-ids.json gains two Omaha endpoints (rm1/rm2) alongside the existing S3 URL. Makefile adds --verbose to both download invocations. The CI workflow's test_device job is disabled, and release no longer waits for it.

Changes

Download Provider URL Refactor and Provider Config

Layer / File(s) Summary
download_version refactor + provider URL config
codexctl/updates.py, data/version-ids.json
Removes BASE_URL/BASE_URL_V3 local variable definitions and the version-split URL logic. Method now computes file_name by a version boundary (3, 11, 2, 5), then iterates all external_provider_urls, building each file_url by substituting both REPLACE_ID (with version_id) and REPLACE_NAME (with file_name); returns on first success or logs error and returns None. Provider list in version-ids.json gains two Omaha S3 URLs for rm1 and rm2 using the REPLACE_NAME placeholder.
Makefile --verbose flag
Makefile
Adds --verbose to both python -m codexctl download invocations in the firmware download rules.

CI Workflow - Disable test_device Job

Layer / File(s) Summary
test_device job disable and release dependency update
.github/workflows/main.yml
Comments out the entire test_device job and its steps (artifact download, disk space cleanup, in-device firmware download). The release job's needs list is updated to remove the test_device dependency, allowing release to proceed after remote and device jobs complete.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • Jayy001/codexctl#155: Both PRs modify codexctl/updates.py's UpdateManager.download_version to use provider URL lists (external_provider_urls) for download attempts and update the associated data/version-ids.json URL structures.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the main change: refactoring download logic to use only external provider URLs instead of building direct URLs with BASE_URL variables.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch Eeems-patch-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Eeems Eeems marked this pull request as ready for review June 23, 2026 22:28
@rmitchellscott

Copy link
Copy Markdown
Contributor

Tested on rM2 from 3.9.5.2026 -> 3.11.2.5

@Eeems Eeems merged commit 6a47478 into main Jun 23, 2026
10 of 11 checks passed
@Eeems Eeems deleted the Eeems-patch-2 branch June 24, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants