Fix #183

[Eeems]

Summary by CodeRabbit

• Bug Fixes
  • Refined the update installation compatibility check for devices using the legacy update engine. The “new update engine required” block now applies only when the target version is not 3.11.2.5. This allows installing that specific version on legacy-engine devices while keeping incompatible images blocked for other versions.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 771ded4e-fe63-488e-abf2-30bb4d5f8453

📥 Commits

Reviewing files that changed from the base of the PR and between 56dcf94 and f6d6838.

📒 Files selected for processing (1)

• codexctl/__init__.py

🚧 Files skipped from review as they are similar to previous changes (1)

• codexctl/init.py

---

Walkthrough

In Manager.call_func, the condition that raises a SystemError when a device on the old update engine attempts to install an image requiring the new engine is narrowed by adding a version_number != "3.11.2.5" check, exempting that specific version from the block.

Changes

Old-engine downgrade guard

Layer / File(s)	Summary
Exempt 3.11.2.5 from old-engine SystemError codexctl/__init__.py	The update_file_requires_new_engine guard in Manager.call_func now skips the SystemError when version_number == "3.11.2.5", making that version installable on devices still running the old update engine.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Fix #183' is minimal and refers to an issue but does not convey any meaningful information about what was actually fixed in the changeset.	Use a more descriptive title that explains the actual fix, such as 'Narrow downgrade-prevention guard for old update engine' or 'Fix update engine compatibility check for version 3.11.2.5'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch Eeems-patch-1

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}