Skip to content

Pivot usability improvements#183

Open
Kannoma wants to merge 9 commits into
mainfrom
pivot-usability-improvements
Open

Pivot usability improvements#183
Kannoma wants to merge 9 commits into
mainfrom
pivot-usability-improvements

Conversation

@Kannoma

@Kannoma Kannoma commented May 7, 2026

Copy link
Copy Markdown
Collaborator
image image
  • Fixed pivot marker visual glitch when moving geometries in deep group hierarchies

@Kannoma
Kannoma requested a review from JannisX11 May 7, 2026 12:33
@Kannoma Kannoma self-assigned this May 7, 2026
@JannisX11

Copy link
Copy Markdown
Owner

Hey, I've set the default tool for double click tool switching back to the Resize Tool, no need to break existing workflows for this. And I've removed the restriction for this to the Hytale format, I think that just makes it more confusing and is not mentioned in the settings descriptions.

Regarding the Follow Pivot toggle, the only issue that I've found is that it doesn't quite work with Undo. I can undo a change and it moves back the pivot, but when I redo it again it doesn't follow the object again.

@Kannoma

Kannoma commented May 14, 2026

Copy link
Copy Markdown
Collaborator Author

I will investigate this.

Also should we consider a setting toggle for setting the double click as pivot<->move swap? I was thinking maybe we can create a toggle like "Hytale Team preference" so the team has the change requested without tracking which setting does what and we don't break any workflow

@Kannoma

Kannoma commented May 14, 2026

Copy link
Copy Markdown
Collaborator Author

Should have the undo-redo issue fixed with my latest change

@JannisX11 JannisX11 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo support is much better, yeah!
Only issue now is whenever transforming a group or multiple groups, the cube pivot transformations usually don't make sense anymore. You can test this by opening any complex model, selecting the root and moving it, and then investigating the individual cube pivots. The issue also reveals itself in the preview of the pivot while moving the mouse.
Changing this might be as easy as testing if a group is selected, and if so skipping this whole system. Moving all pivots is the default behavior in that case either way. Maybe there is a case for supporting the "Keep Pivot" behavior when moving a single group with cubes inside, but I think in that case you might as well just select only the cubes.

@Kannoma

Kannoma commented May 28, 2026

Copy link
Copy Markdown
Collaborator Author

Implemented the fix for groups.
Only note: I can't figure out how to get it working well on mixed selection of groups + individual elements. I think it's acceptable limitation for now but I want to wait for your green light before merging it to main @JannisX11 cc @ThomasFrickHytale

@Kannoma
Kannoma requested a review from JannisX11 May 28, 2026 14:57

@JannisX11 JannisX11 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The group detection didn't work because Outliner.selected only contains elements, not groups. Changed it to just check for selected groups, and it works now. Approved!

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants