Skip to content

Fix texture properties window crash [Figura Plugin] #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JannisX11 merged 1 commit into from
Jul 17, 2026
+14 −6
Merged

Fix texture properties window crash [Figura Plugin] #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,7 +1095,7 @@
"icon": "icon.svg",
"description": "Create models for the Figura mod in a custom format that optimizes Blockbench to work with Figura models.",
"tags": ["Minecraft: Java Edition", "Figura"],
"version": "0.1.4",
"version": "0.1.5",
"min_version": "4.8.0",
"variant": "both",
"await_loading": true,
Expand Down
18 changes: 13 additions & 5 deletions plugins/figura_format/figura_format.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,21 @@
function getValidLuaIndex(str) {
return isValidLuaIdentifier(str) ? `.${str}` : `["${str}"]`
}
const bbv5 = (()=>{
let bbv5 = true;
try {
bbv5 = parseInt(Blockbench.version[0]) >= 5;
} catch {}
return bbv5;
})();

BBPlugin.register('figura_format', {
title: "Figura Model Format",
author: "Katt (KitCat962)",
icon: "icon.svg",
description: "Create models for the Figura mod in a custom format that optimizes Blockbench to work with Figura models.",
tags: ["Minecraft: Java Edition", "Figura"],
version: "0.1.4",
version: "0.1.5",
min_version: "4.8.0",
variant: "both",
await_loading: true,
Expand Down Expand Up @@ -114,11 +121,11 @@
click() {
let path = []
let element
if (parseInt(Blockbench.version[0]) < 5) {
element = Group.selected || Outliner.selected[0] // < v5
if (bbv5) {
element = Group.selected[0] || Outliner.selected[0] // >= v5
}
else {
element = Group.selected[0] || Outliner.selected[0] // >= v5
element = Group.selected || Outliner.selected[0] // < v5
}
while (element !== "root") {
path.unshift(element.name)
Expand Down Expand Up @@ -534,7 +541,8 @@
// In the Texture Properties Dialog specifically, remove the Render Mode field
const DialogBuild = Dialog.prototype.build
Dialog.prototype.build = function () {
if (Format === format && this.id == 'texture_edit') delete this.form.render_mode
if (!bbv5 && Format === format && this.id == 'texture_edit') delete this.form.render_mode
if (bbv5 && Format === format && this.id == 'texture_edit') delete this.form_config.render_mode
DialogBuild.call(this)
}

Expand Down
Loading