Resolve Credentials issues and queue URL issues - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to Don't alter Aws.config, it's global and can affect other plugins ixixi/fluent-plugin-sqs#39 and Pass credentials directly to the Client classes ixixi/fluent-plugin-sqs#40, we avoid setting
Aws.configbecause that is shared between all AWS SDK clients in use.Related to Error: Credential should be scoped to a valid region, not 'queue'. (Aws::SQS::Errors::SignatureDoesNotMatch) aws/aws-sdk-ruby#1620, we avoid asking for
sqs_urlas a configuration option, because depending on the AWS SDK version you have, it may not be able to handle both formats of SQS URL that are in use currently e.g.https://{REGION}.queue.amazonaws.com/{ACCOUNT_ID}/{QUEUE_NAME}https://sqs.{REGION}.amazonaws.com/{ACCOUNT_ID}/{QUEUE_NAME}