Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
eba85c4
Extract property name parsing helpers from GenericPropertyObjectImpl
JakaMohorko Aug 10, 2026
62da18b
Extract remaining pure statics from GenericPropertyObjectImpl
JakaMohorko Aug 10, 2026
317b30f
Replace recursive child-property dispatch with iterative getParentObject
JakaMohorko Aug 10, 2026
40ca68b
Extract selection key/value conversion into shared helpers
JakaMohorko Aug 10, 2026
4bac6ba
Decompose getPropertyAndValueInternal
JakaMohorko Aug 10, 2026
d3223fe
Rename cloneContainerValue to cloneIfContainerValue
JakaMohorko Aug 10, 2026
3cdde9e
Split getPropertyAndValueInternal into bind and read helpers
JakaMohorko Aug 10, 2026
6175283
Deduplicate default-value comparison in local value writes
JakaMohorko Aug 10, 2026
72e05c3
Add combined bind+read overload; drop redundant re-bind in clearPrope…
JakaMohorko Aug 10, 2026
89335a9
Rename updatingPropsAndValues to batchedUpdates
JakaMohorko Aug 10, 2026
6a5751b
Share the child-object iteration between begin/endUpdate propagation
JakaMohorko Aug 10, 2026
8d0e068
Deduplicate getOnPropertyValueWrite/getOnPropertyValueRead
JakaMohorko Aug 10, 2026
bbe5db8
Route hasProperty child paths through getParentObject
JakaMohorko Aug 10, 2026
e9ff145
Converge property lookup on getUnboundPropertyOrNull
JakaMohorko Aug 10, 2026
f38cc83
Drop redundant hasProperty pre-check in getPropertyValueEventInternal
JakaMohorko Aug 10, 2026
f923950
Collapse protected/plain duplication in clearPropertyValueInternal ob…
JakaMohorko Aug 10, 2026
baab340
Extract shared three-tier event dispatch from callPropertyValueRead/W…
JakaMohorko Aug 10, 2026
2e9035d
Merge configureClonedMembers overloads via namespace-scoped ClonePara…
JakaMohorko Aug 10, 2026
6acc25b
Simplify getPropertiesInternal ordering tail
JakaMohorko Aug 10, 2026
ea0233a
Rename effectiveName to resolvedName
JakaMohorko Aug 10, 2026
071bafa
Move forEachUnfrozenChildObject to private scope
JakaMohorko Aug 10, 2026
b3bfd3d
Remove dead default-value walk from disableCoreEventTrigger
JakaMohorko Aug 10, 2026
f97c0d9
Make property write events exception-safe
JakaMohorko Aug 10, 2026
3029dcb
Dispatch child-path clears to the child during updates, same as sets
JakaMohorko Aug 10, 2026
8de1611
Delegate object-property clears to the nested object
JakaMohorko Aug 10, 2026
570bd63
Extract bindForWrite for the write-path property lookup
JakaMohorko Aug 10, 2026
884a439
Extract the write validation pipeline into details::checkAndCoerceWrite
JakaMohorko Aug 10, 2026
416e3d3
Clean up property object helpers
JakaMohorko Aug 11, 2026
a4523a6
Bind selection-set properties once
JakaMohorko Aug 11, 2026
e46b6f8
Decompose getPropertiesInternal into named steps
JakaMohorko Aug 11, 2026
0f8010b
Deduplicate hasDuplicateReferences
JakaMohorko Aug 11, 2026
bcd6d59
Tighten legacy lock accessors
JakaMohorko Aug 11, 2026
584228a
Standardize brace usage in property object headers
JakaMohorko Aug 11, 2026
22ecfe6
Rename write-path helpers for clarity
JakaMohorko Aug 11, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ class PropertyObjectClassBuilderImpl : public ImplementationOf<IPropertyObjectCl
ListPtr<IString> customOrder;
WeakRefPtr<ITypeManager> manager;

bool hasDuplicateReferences(const PropertyPtr& prop) const;
ListPtr<IProperty> getProperties() const;
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ class PropertyObjectClassImpl : public ImplementationOf<IPropertyObjectClass, IP
ErrCode getInheritedProperties(ListPtr<IProperty>& properties) const;

ErrCode serializeProperties(ISerializer* serializer);

bool hasDuplicateReferences(const PropertyPtr& prop);
};


Expand Down
Loading
Loading