ci: fix sign-release self-check on SHA256SUMS.txt - #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verification loop required every downloaded file to be listed in SHA256SUMS.txt, including SHA256SUMS.txt itself, which never lists itself.
In run 32026575413 the loop verified 6 assets before failing on SHA256SUMS.txt (DevNav-scoop-arm64.zip, DevNav-scoop-x64.zip, DevNav.psd1, DevNav.psm1, DevNavSetup-arm64.exe, DevNavSetup-x64.exe — all OK); the remaining assets were never reached because the loop aborted.
This change skips only SHA256SUMS.txt in that listing check. The hash verification of every other asset is unchanged.