refactor: deduplicate PowerShell shortcut usage dispatch - #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Invoke-DevShortcutCommand(default branch) andInvoke-DevNavigator(dev shortcutwith no items) each contained the same English usagethrowduplicated twice consecutively before the Spanishthrow— a known copy-paste defect in the shortcut dispatch flow.Refactor
Resolve-DevShortcutUsageError(approved verb, not exported): consults the language and throws the exact existing EN or ES usage message.ifblocks are gone. Behavior-preserving: identical messages, identical throws, same public API/exports, no config format or Rust CLI changes. (Audited the whole module for the same pattern: no other occurrences.)Regressions
Invoke-DevShortcutCommandtoo-many-args usage: EN and ES messages asserted (new).Invoke-DevNavigator -Command shortcutwith no arguments: EN and ES usage asserted (new).Coverage post
PowerShell commands 565/673 (83.95%), lines 360/431 (83.53%) — both gates >= 80% PASS (denominator shrank with the removed duplicate lines). Pester: 118 passed / 0 failed.
Gates
validate-powershell (parser + PSScriptAnalyzer) OK · Pester + coverage gate OK · cargo test 171 OK · node bootstrap tests OK · git diff --check OK.