Repository navigation
fix(dylib): move the live page when Little Dia opens it in Dia - #448
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Open in Dia (and ⌘O) in a Little Dia window now moves the page itself into the main window instead of opening its address again.
Why
Closes #439. The page was reopened in a new tab and the small window closed, so it reloaded and lost typed text, scroll position and anything in progress. The tab is now moved across as it is. If the move fails, it falls back to opening the address as before.
Proof
A test page showing a load id made at load, a counter, and a text field, scrolled to 2400, after Open in Dia.
Before, a new load: new id, empty field, scroll 0.
After, the same page: same id, text kept, scroll kept, counter still running.
Same result from the button and from ⌘O, with tabs in the sidebar and at the top.
Tested on
Checklist